Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump EnzymeCore compat to 0.6 - 0.8 #666

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Bump EnzymeCore compat to 0.6 - 0.8 #666

merged 1 commit into from
Sep 23, 2024

Conversation

penelopeysm
Copy link
Member

Combines changes from #664 and #665 to help CI get along.

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 10983214109

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 75.931%
Totals Coverage Status
Change from base Build 10856622994: -1.6%
Covered Lines: 2672
Relevant Lines: 3519
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10983214109

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.486%
Totals Coverage Status
Change from base Build 10856622994: 0.0%
Covered Lines: 2712
Relevant Lines: 3500
💛 - Coveralls

torfjelde
torfjelde approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!:)

@penelopeysm penelopeysm added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit 0e40bd0 Sep 23, 2024
11 of 12 checks passed
@penelopeysm penelopeysm deleted the py/enzyme-compat branch September 23, 2024 11:00
This was referenced Sep 23, 2024
Closed
Closed
@wsmoses
Copy link
Contributor

wsmoses commented Sep 23, 2024

@torfjelde @penelopeysm could this get a release soon? apparently it's holding back other parts of the ecosystem like lux

@penelopeysm
Copy link
Member Author

I've released 0.29.0.

@wsmoses
Copy link
Contributor

wsmoses commented Sep 23, 2024

amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torfjelde torfjelde torfjelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@penelopeysm @coveralls @wsmoses @torfjelde